Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eks and vpc module versions (breaking changes) #338

Open
ankitm123 opened this issue Mar 10, 2022 · 2 comments
Open

Update eks and vpc module versions (breaking changes) #338

ankitm123 opened this issue Mar 10, 2022 · 2 comments

Comments

@ankitm123
Copy link
Member

ankitm123 commented Mar 10, 2022

Summary

We should update the eks module version to the latest, and check what are the issues we have.
There are quite a few breaking changes (including removal of map_roles and launch templates)
https://github.com/terraform-aws-modules/terraform-aws-eks/releases/tag/v18.0.0

@ankitm123 ankitm123 reopened this Mar 15, 2022
@msvticket
Copy link
Member

An attempt at an inventory of things we need to do to preserve the existing functionality of the cluster module when updating the eks module (using https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/docs/UPGRADE-18.0.md as reference):

  • manage aws-auth configmap ourselves
  • configure kubeconfig (probably needed for the above)
  • rename and change use of
    • node_groups -> eks_managed_node_groups
    • worker_groups -> self_managed_node_groups
  • 'To use the legacy (< 18.x) resource naming convention, set prefix_separator to "".'

We should use the techniques described in https://developer.hashicorp.com/terraform/language/modules/develop/refactoring to make the upgrade smooth for our users.

@msvticket
Copy link
Member

More information here terraform-aws-modules/terraform-aws-eks#1744 (comment)

@msvticket msvticket mentioned this issue Nov 23, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants