Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline: SCM Step page - GitSCM docs require an extra click #6010

Open
kwilson33 opened this issue Feb 7, 2023 · 6 comments
Open

Pipeline: SCM Step page - GitSCM docs require an extra click #6010

kwilson33 opened this issue Feb 7, 2023 · 6 comments
Labels

Comments

@kwilson33
Copy link

Problem with the Pipeline: SCM Step page

The page is missing the dropdown menu for the GitSCM class. A few months ago from today (2/7/23) I remember there being one, showing all of the options. Now, there is just an 'scmGit' drop-down that is empty.

Screenshots

image
Empty 'scmGit' dropdown

Possible Solution

Add documentation for the scmGit/GitSCM class.

N/A

@kwilson33 kwilson33 added the bug label Feb 7, 2023
@MarkEWaite
Copy link
Contributor

MarkEWaite commented Feb 7, 2023

The scmGit page has been deduplicated from the many, many locations where it was inserted and placed in its own page. That dramatically improved page load time and made the pages much more usable. It also changed the interaction with that link. It now requires a two step process to reach the scmGit documentation.

When the page first opens, that region looks like this:

scmGit-01-initial-presentation

  1. Click the "+" to the left as scmGit as though you were expanding it. The word scmGit is then converted from a text string into a hyperlink. That results in something that looks like this:

scmGit-03-after-clicking-plus-sign-with-hyperlink

  1. Click the scmGit hyperlink to navigate to the scmGit page. That opens a page that has this:

scmGit-04-after-cllicking-hyperlink

I'm sure that there is more that can be done to improve the navigation beyond the current two step process. The page load time performance from the GSoC 2022 project were so significant that we accepted this additional step in order to read the scmGit page.

@MarkEWaite MarkEWaite changed the title Pipeline: SCM Step page - Missing documentation for GitSCM class. Now there is an 'scmGit' dropdown, but it is empty. Pipeline: SCM Step page - GitSCM documentation needs an extra click Feb 7, 2023
@MarkEWaite MarkEWaite changed the title Pipeline: SCM Step page - GitSCM documentation needs an extra click Pipeline: SCM Step page - GitSCM docs require an extra click Feb 7, 2023
@kwilson33
Copy link
Author

Oh wow I don't know how I didn't realize that there was a hyperlink, thanks!
My main issue was that I couldn't find the scmGit documentation, so now that I can view it, I'm relieved.
Though, I do agree that the 2 step process could probably be improved.

@MarkEWaite
Copy link
Contributor

I'd love to have someone improve that interaction, but I'm not the person to do it. No JavaScript skills and no real interest in developing them.

@kwilson33
Copy link
Author

kwilson33 commented Feb 7, 2023

Understood. Not a big deal 😊.

Related question, and I think you'd be able to help.
What is the most up to date page on GitSCM/scmGit?

I see there are these 2 pages

Both have similar content, and I believe are documenting the same functionality.

Maybe this should be opened up in another issue?

@MarkEWaite
Copy link
Contributor

MarkEWaite commented Feb 7, 2023

Both have similar content, and I believe are documenting the same functionality.

https://www.jenkins.io/doc/pipeline/steps/params/scmgit/ is the most current page.

Already opened as an issue in:

@lemeurherve
Copy link
Member

lemeurherve commented Nov 2, 2023

Since #6677 these outdated pages return (for now at least) a 403 error, see jenkins-infra/helpdesk#3360 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants