-
-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving Chromecast Integration #1298
base: master
Are you sure you want to change the base?
Conversation
wait for 15 seconds before actually shutting down. this is because chromecast playback somethimes seems to play a track and when that one stops, plays another. That means, that stop is called in the mean time which causes the notification to disappear and the wake lock to be released which can cause errors an restarting the background service. to prevent this we wait 15 seconds before actually stopping the service, giving chromecast/jellyfin client time to start another track.
Also fix the bug where swiping on the timeline does not work when casting to TV using Google Cast. Playback stops when you want to go to another time. This issue happens when sending from Jellyfin Web. |
Thanks for looking into this! So far, the changes look pretty good. Please tell me when you have specific questions about fixing the remaining TODOs. |
What's the state of this? Would you prefer to continue working on it first, or do you think we can already merge the existing changes? |
Hey, sorry for the absurdly late response. I have been using the debug app for quite some time now and it was much more reliable than the normal version in regards to chrome-casting. If someone could look over the changes I have done who has more experience in android development and says that the changes make sense I believe this PR would make things better. It is, however, not perfect. Things get out of sync. It seems like in the browser part events are filtered out and do not get passed down to the app sometimes. Unfortunately my knowledge is not deep enough to get the grater picture but I think to make things considerably better there would need to be a shared effort between android and web repository. |
Changes
This PR is targeting Chrome Cast support in the Jellyfin Android app. Chromecast seems to have multiple issues in my environment and I am aiming to make it a smoother experience.
I am by far NOT an expert in Android development but I was involved in Android development, so I am not absolutely incompetent to make improvements. However my PRs should be taken with a grain of salt and I will probably need a fair amount of help.
Changed RemotePlayerService wake lock and foreground binding to ensure it does not get killed by OS
TODOs:
Issues