Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional language parameter to GetTvShowVideosAsync #500

Closed
DineshSolanki opened this issue Jul 7, 2024 · 0 comments · Fixed by #501
Closed

Add optional language parameter to GetTvShowVideosAsync #500

DineshSolanki opened this issue Jul 7, 2024 · 0 comments · Fixed by #501

Comments

@DineshSolanki
Copy link
Contributor

The GetTvShowVideosAsync doesn't accept the language parameter which is internally supported though.
While I know we can set the default language, I have a use case where, if no videos are found for the result of default language, I would like to retry with the original language of the TV show.

For example

TV show id 84105 will return no video result for any other language except hi-IN (its original language)
DineshSolanki added a commit to DineshSolanki/TMDbLib that referenced this issue Jul 8, 2024
@DineshSolanki
fix jellyfin#500: Add language parameter to GetTvShowVideosAsync method
8e61bce 
The GetTvShowVideosAsync method has been updated to include an optional language parameter. This parameter allows users of the TMDbClient library to retrieve videos in a specific language instead of only in default(en-US)
DineshSolanki added a commit to DineshSolanki/TMDbLib that referenced this issue Jul 8, 2024
@DineshSolanki
fix jellyfin#500: Add language parameter to GetTvShowVideosAsync method
35b084f 
The GetTvShowVideosAsync method has been updated to include an optional language parameter. This parameter allows users of the TMDbClient library to retrieve videos in a specific language instead of only in default(en-US)
This was referenced Jul 8, 2024
Merged
Open
crobibero pushed a commit that referenced this issue Jul 22, 2024
@DineshSolanki
fix #500: Add language parameter to GetTvShowVideosAsync method (#501)
7a6477f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #500: Add language parameter to GetTvShowVideosAsync method DineshSolanki/TMDbLib
1 participant
@DineshSolanki