Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis backend for LSI #93

Open
ibnesayeed opened this issue Jan 6, 2017 · 1 comment
Open

Redis backend for LSI #93

ibnesayeed opened this issue Jan 6, 2017 · 1 comment

Comments

@ibnesayeed
Copy link
Contributor

ibnesayeed commented Jan 6, 2017

We have successfully abstracted datastructure of Bayes which allowed us to implement an alternate Redis storage backend (#81) while making it possible to easily add more backends (such as ORM based). However, I found it little difficult to follow along the flow of the LSI implementation to understand all the datastructures needed for that. Can someone give a high-level overview of datastructures of LSI, their relationship, and desired operations?

As a side note, can we please make sure to abstract the datascructure away from the logic from the day one of every new algorithm we might implement as indicated in #88.

@Ch4s3
Copy link
Member

Ch4s3 commented Jan 6, 2017

The LSI functionality/implementation is a pretty tricky to follow. Most of it hasn't been changed since it was first written. I'm not sure I could adequately explain how to go about abstracting the pieces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants