You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is to allow atomic comparison of the impact of the proposed changes of a PR in [WIP] mode.
Scenario: Examine impact of all proposed commits on performanceGiven that I have a WIP pull request with multiple individually pushed commits
And that those commits encompass meaningful and significant changes
When I examine the "report page" url for a commit
Then I should be able to inspect the report page of any "previous commit" from the current page
And I should be able to inspect the report page of any "following commit" from the current page
The benefit from this is that contributors will have easier insight on the course of their final proposal. For example, if a WIP-PR has 5 individually pushed commits with 3 commits that improve performance and the following 2 that slightly lower performance, the author would have to currently either:
open 5 individual tabs (to report page) to closely examine the report of each commit
or traverse back and forth on the currently open tab
Related requirements:
change current :details_url from /:sha.html to /:owner/:repo/:pull_id/:sha.html
The text was updated successfully, but these errors were encountered:
This is currently impossible in the generated HTML. Since each checkrun is atomic, there is no knowledge of past or future commits in the PR.
What we could maybe do is have GitHub keep a check run for each commit in the Checks tab, instead of overwriting the last Performance Check when a new one is added.
This is to allow atomic comparison of the impact of the proposed changes of a PR in
[WIP]
mode.The benefit from this is that contributors will have easier insight on the course of their final proposal. For example, if a WIP-PR has 5 individually pushed commits with 3 commits that improve performance and the following 2 that slightly lower performance, the author would have to currently either:
Related requirements:
:details_url
from/:sha.html
to/:owner/:repo/:pull_id/:sha.html
The text was updated successfully, but these errors were encountered: