-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add regression tests #19
Comments
In theory, you could build a bare-bones site with all tags needed to be observed, included in the |
That's mostly what our integration tests already do. The goal here is to specifically use real world sites. That way, we can also test popular plugins, and also check some of the weird ways that users use (and abuse) Jekyll in ways we haven't considered. |
👍 👍 |
Could a visual diff with Pupeteer headless browser help us spot differences in the rendering? |
Perhaps. Hopefully there would be zero differences the vast majority of the time. If there are zero differences in the output, this check should pass ✅ |
It would be cool to be able to test two refs and warn of any differences between the two builds.
sites
with Jekyll version Asites
with Jekyll version BI'm not sure there would be an automated way to decide if the differences were minimal enough to be acceptable. Perhaps the diff could just be posted as is, so that it could be reviewed by a person. It should be obvious if eg. a tag or plugin has stopped working.
The text was updated successfully, but these errors were encountered: