Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Dark code blocks #24

Open
illusion0001 opened this issue Feb 14, 2021 · 4 comments · May be fixed by #124
Open

Feature Request: Dark code blocks #24

illusion0001 opened this issue Feb 14, 2021 · 4 comments · May be fixed by #124
Assignees
@jeffreytse
Labels
enhancement New feature or request

Comments

@illusion0001
Copy link

illusion0001 commented Feb 14, 2021 •
edited
Loading

As title suggested, currently when viewing code blocks in dark mode, the background and text remain in light theme.

https://jeffreytse.github.io/jekyll-theme-yat/markdown/2018/12/05/an-exhibit-of-markdown.html#h-code-block
@jeffreytse jeffreytse self-assigned this Feb 17, 2021
@jeffreytse jeffreytse added the enhancement New feature or request label Feb 17, 2021
@jeffreytse
Copy link
Owner

Hi @illusion0001

I will take a consideration for this feature request, welcome to star this repository for the updates in the near future.

Thanks and regards

@illusion0001
Copy link
Author

illusion0001/illusion0001.github.io@8d209cb

I changed the hardcoded colors instead. perhaps there's a better way to do this?

image

@jeffreytse
Copy link
Owner

Hi @illusion0001

Yes, there is a better way by taking a dark theme for the code block. Now there are several open source works need to be maintained. Thanks for supporting my open source work! I will try to do this feature as soon as possible.

Thanks and regards

tchebb added a commit to tchebb/jekyll-theme-yat that referenced this issue Aug 24, 2023
@tchebb
Add a dark theme for code blocks
6418e50 
Now that code highlighting is just a normal stylesheet, it's easy to add
a separate set of dark-mode rules. Do so and update the documentation.

Fixes jeffreytse#24
@tchebb tchebb linked a pull request Aug 24, 2023 that will close this issue
Open
tchebb added a commit to tchebb/jekyll-theme-yat that referenced this issue Aug 24, 2023
@tchebb
Add a dark theme for code blocks
3044ece 
Now that code highlighting is just a normal stylesheet, it's easy to add
a separate set of dark-mode rules. Do so and update the documentation.

Fixes jeffreytse#24
tchebb added a commit to tchebb/jekyll-theme-yat that referenced this issue Aug 25, 2023
@tchebb
Add a dark theme for code blocks
1a91020 
Now that code highlighting is just a normal stylesheet, it's easy to add
a separate set of dark-mode rules. Do so and update the documentation.

Fixes jeffreytse#24
@holgerstolzenberg
Copy link

Any chance to get that feature rollin' as the PR is already there...!?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffreytse jeffreytse

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@holgerstolzenberg @jeffreytse @illusion0001