Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postFile infinite loop #181

Open
scenaristeur opened this issue Dec 3, 2020 · 2 comments
Open

postFile infinite loop #181

scenaristeur opened this issue Dec 3, 2020 · 2 comments

Comments

@scenaristeur
Copy link
Contributor

Ola it's another time me & myself.

  • "solid-file-client": "^1.2.2",

I encounterd a infinite loop using postFile()
Try to catch error to display a notification, i gave volontarily postFile a wrong url and felt in an infinite loop

sfc postFile

whereas a createFile throw me an error without infinite loop

sfc createfile

Is there something wrong with postFile ?

@bourgeoa
Copy link
Collaborator

bourgeoa commented Dec 4, 2020

CreateFile() is using putFile() to is directectly using a PUT
postFile() uses POST this imply it must create intermediate directories. To do that it is using createFolder()

  • Can you try to use postFile() with the option createPath = false, postFile() will not call createFolder()
  • do you have the same problem using solid-file-client v1.2.0 ?

@bourgeoa
Copy link
Collaborator

bourgeoa commented Dec 6, 2020

I'm unable to reproduce any problem with postFile() checked tests, checked with creating files in root or any other folder and everything seems OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants