New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up code #29

Open

2 tasks

jdittrich opened this issue Jun 14, 2016 · 1 comment

Assignees

Owner

jdittrich commented Jun 14, 2016 •

edited

Loading

The code in https://github.com/jdittrich/ep_autocomp/blob/master/static/js/autocomp.js is messy.

It is commented, but the order of the functions does not make sense and the comments should be reviewed.

moveUp and moveDown functions should be adjacent
createAutocompHTML does return undefined, not "?"

The text was updated successfully, but these errors were encountered:

Collaborator

lpagliari commented Jun 14, 2016

createAutocompHTML does return undefined, not ?

Yes. :-) It does not return anything, it is used to display new suggestions to the user.

jdittrich self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment