New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Env history not managed based on history_size #6

Open

nitinsurya opened this issue Sep 19, 2020 · 1 comment

nitinsurya commented Sep 19, 2020

In the following locations of the code:

https://github.com/jcwleo/curiosity-driven-exploration-pytorch/blob/master/envs.py#L188-L189
https://github.com/jcwleo/curiosity-driven-exploration-pytorch/blob/master/envs.py#L286-L287

history is updated assuming the history size is 4. Shouldn't it instead be

self.history[:self.history_size-1, :, :] = self.history[1:, :, :]
self.history[self.history_size-1, :, :] = self.pre_proc(obs)

The text was updated successfully, but these errors were encountered:

Owner

jcwleo commented Dec 23, 2020

@nitinsurya
If you make PR, I'll approve that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment