From 53ebb929194e0f0438d58fa27d96983d2948387d Mon Sep 17 00:00:00 2001 From: jcorporation Date: Sat, 29 Jul 2023 20:45:08 +0200 Subject: [PATCH] Fix: display all values in playback card #1076 --- CHANGELOG.md | 1 + htdocs/js/Playback.js | 7 +++---- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 926e9a398..f0bc7da2b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,7 @@ This is a small bug fix release. - Fix: set translated title for navbar icons - Fix: jukebox list context menu actions - Fix: calculate correct myMPDuri for IPv6 [::] +- Fix: display all values in playback card #1076 *** diff --git a/htdocs/js/Playback.js b/htdocs/js/Playback.js index 34c91a5c5..3ddc1eb01 100644 --- a/htdocs/js/Playback.js +++ b/htdocs/js/Playback.js @@ -216,9 +216,9 @@ function parseCurrentSong(obj) { */ function setPlaybackCardTags(songObj) { if (songObj.webradio === undefined) { + elHideId('cardPlaybackWebradio'); + elShowId('cardPlaybackTags'); for (const col of settings.colsPlayback) { - elHideId('cardPlaybackWebradio'); - elShowId('cardPlaybackTags'); const c = document.getElementById('current' + col); if (c === null) { continue; @@ -236,14 +236,13 @@ function setPlaybackCardTags(songObj) { if (value === undefined) { value = '-'; } + elReplaceChild(c.querySelector('p'), printValue(col, value)); if (checkTagValue(value, '-') === true || settings.tagListBrowse.includes(col) === false) { - elClear(c.querySelector('p')); c.querySelector('p').classList.remove('clickable'); } else { - elReplaceChild(c.querySelector('p'), printValue(col, value)); c.querySelector('p').classList.add('clickable'); } setData(c, 'name', value);