Change Vote.object_id type to TextField to support other primary key types like UUIDField. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
==========================================
+ Coverage 30.35% 31.13% +0.78%
==========================================
Files 8 8
Lines 313 318 +5
Branches 51 61 +10
==========================================
+ Hits 95 99 +4
Misses 216 216
- Partials 2 3 +1
Continue to review full report at Codecov.
|
…types like UUIDField.
hramezani
force-pushed
the
change_object_id
branch
from
1f50d0a to
08f0479
Compare
jezdez
approved these changes
Dec 3, 2021
|
@jezdez Thanks for the review. |
|
@hramezani Sure, @gholamiayub and me are the project leads, but realistically I won't have time to do this soon. |
|
@jezdez I can take care of the release and be be a project lead if it's ok for you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23