Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request for OVH Gateway #625

Open
nalo26 opened this issue May 17, 2023 · 3 comments
Open

Pull request for OVH Gateway #625

nalo26 opened this issue May 17, 2023 · 3 comments

Comments

@nalo26
Copy link

nalo26 commented May 17, 2023

Hi!

I'm reaching you today because, for the needs of a project of mine, I created a gateway with OVH SMS service.

I wanted to know if you would be interested in a merge request of this gateway feature, for an easy integration in the future.
If you'd agree, I'd take the time to format the code as you expect it.

Thanks in advance for your answer,
nalo_

@claudep
Copy link
Contributor

claudep commented May 17, 2023

I would say at first that the recent plugin architecture in this package was designed to allow easier integration of custom methods or providers. So ideally you should be able to setup an external package that could be integrated without the need to commit the code in this package. Is this realistic? Then we could list such external packages/plugins in d2fa docs.

@nalo26
Copy link
Author

nalo26 commented May 22, 2023

Sounds right to me, I will do an external package.
Will keep you informed when it's done.

Thanks for your reply!

@nalo26
Copy link
Author

nalo26 commented May 23, 2023

Hello again,
Please find here the PyPI link to the extension, as promised : https://pypi.org/project/django-two-factor-auth-ovh-gateway/

Let me know if you need some additional information!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants