adds optional cursor override to support django schema tenants #158
+13
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimizukawa
reviewed
Oct 27, 2024
Comment on lines
+1407
to
+1408
| if DJANGO_REDSHIFT_ENABLE_TENANT_SCHEMA: | ||
| cursor.execute(f"SET SEARCH_PATH TO '{connection.schema_name}', public") |
There was a problem hiding this comment.
I don't think this is a feature of the Redshift Backend.
I understand that you can't use ‘django_tenants.postgresql_backend’ provided by django-tenants, but I think you should implement a DatabaseWrapper in your application, as django-tenants does.
https://github.com/django-tenants/django-tenants/blob/c02b5a46ae8abc089c3f5f355b4d116e25572a6a/django_tenants/postgresql_backend/base.py#L60
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject: Add support for django tenants integration
Feature or Bugfix
Purpose
SEARCH_PATHto the correct schema based on the context. We can achieve this by setting the search path on the cursor prior to returning it, making consequent queries context aware.Detail
SEARCH_PATHto the relevant tenant & public schemas.Relates
Resolves #157