Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Jazzband guidelines for django-polymorphic #553

Open
11 of 12 tasks
jazzband-bot opened this issue Nov 22, 2023 · 10 comments
Open
11 of 12 tasks

Implement Jazzband guidelines for django-polymorphic #553

jazzband-bot opened this issue Nov 22, 2023 · 10 comments
Assignees

Comments

@jazzband-bot
Copy link

jazzband-bot commented Nov 22, 2023

This issue tracks the implementation of the Jazzband guidelines for the project django-polymorphic

It was initiated by @vdboor who was automatically assigned in addition to the Jazzband roadies.

See the TODO list below for the generally required tasks, but feel free to update it in case the project requires it.

Feel free to ping a Jazzband roadie if you have any question.

TODOs

Project details

Description Improved Django model inheritance with automatic downcasting
Homepage https://django-polymorphic.readthedocs.io
Stargazers 1504
Open issues 161
Forks 267
Default branch master
Is a fork False
Has Wiki False
Has Pages True
@AdamDonna
Copy link
Contributor

Code coverage used to be supported and updated PRs with numbers.
eg:// #461

It broke on https://app.codecov.io/gh/django-polymorphic/django-polymorphic/pull/496 and is visible if you check the uploads here https://app.codecov.io/gh/django-polymorphic/django-polymorphic/pulls

We're probably pretty close to having it back up and running

@AdamDonna
Copy link
Contributor

AdamDonna commented Nov 23, 2023

@jezdez I'm seeing CI not using Travis any more and enforcing precommit. Do we need to migrate to github actions and add precommit?

Check if continuous testing works with GitHub Actions

Doesn't read as if it's an enforced migration

@AdamDonna
Copy link
Contributor

Add precommit - It looks like it's required #557

@AdamDonna
Copy link
Contributor

Fixing all links in docs - #559
I suspect the changes in setup.cfg might be breaking and require some caution.

@akx
Copy link
Contributor

akx commented Dec 11, 2023

GHA and Codecov will be enabled by #561.

@akx
Copy link
Contributor

akx commented Dec 12, 2023

A repository admin will need to follow the steps in https://app.codecov.io/gh/jazzband/django-polymorphic/new to get Codecov correctly set up.

@AdamDonna
Copy link
Contributor

AdamDonna commented Dec 20, 2023

@jazzband-bot @jezdez @vdboor Do any of you have the ability to setup coverage for this project? It doesn't appear to be available for non-admins

@hugovk
Copy link
Member

hugovk commented Dec 20, 2023

Looking at a recent build, the problem is that Codecov isn't finding the coverage file locally so cannot upload it. Please see PR #565 to fix it.

@j-antunes
Copy link
Contributor

We have merged PR #565 - At least for now we have coverage working.

@j-antunes
Copy link
Contributor

Upon looking at the project I don't believe there are any other external services used by this project.
I can volunteer to be a maintainer of this project. I need this project o support Django 5.0 since I use this package for my application

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants