Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh token setting/management command documentation not clear #522

Open
clintonb opened this issue Oct 25, 2017 · 2 comments
Open

Refresh token setting/management command documentation not clear #522

clintonb opened this issue Oct 25, 2017 · 2 comments
Labels

Comments

@clintonb
Copy link
Contributor

The documentation around cleartokens command and the REFRESH_TOKEN_EXPIRE_SECONDS setting needs clarification.

The management command documentation mentions a default 1 day delay that is not actually in the codebase. This documentation should clearly state that the REFRESH_TOKEN_EXPIRE_SECONDS setting must be set in order to actually remove expired tokens. Additionally, the management command should alert the user if no tokens will be deleted due to the setting not being set.

The documentation for the REFRESH_TOKEN_EXPIRE_SECONDS setting should also state that the value is required to clear tokens. No emphasis is given to this, so it is too easy to miss this fact. It would also be ideal if a reasonable default were set rather than issuing refresh tokens with unlimited lifetimes.

@doc-E-brown
Copy link
Contributor

Can we extend this to the documentation for using the refresh token in general? It is unclear as to how the refresh token can be used to renew the authorisation token. Thx!

@FMCorz
Copy link

FMCorz commented Mar 1, 2020

I got here because cleartokens did not seem to work for me. I did not realise that the REFRESH_TOKEN_EXPIRE_SECONDS setting was set to None by default. This should be clarified in the docs. I would also suggest to give it a default as IMHO refresh tokens should not be valid forever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants