Adds VALIDATE_USER setting config, if False then don't check email in User model #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed for application that don't have website based interface.
Adds logic to bypass validation error for user model user.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #370 +/- ##
==========================================
- Coverage 86.02% 85.88% -0.14%
==========================================
Files 16 16
Lines 1302 1311 +9
Branches 137 139 +2
==========================================
+ Hits 1120 1126 +6
- Misses 135 136 +1
- Partials 47 49 +2 ☔ View full report in Codecov by Sentry. |
ekerstein
reviewed
May 21, 2022
| "account on this site. Please log in as that user " | ||
| "and try again." | ||
| ) % {'email': email}) | ||
| if User.objects.filter(email__exact=email).exists(): |
There was a problem hiding this comment.
Should it be email__iexact? Because "[email protected]" and "[email protected]' would be the same user.
|
Any update on this PR? I would greatly like to use this feature. My newsletter signup is only public-facing. So I want to require emails to always be inputted and disable the validation to not leak user data per this issue: #183 |
|
I need this PR too as I also do not use the django user system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need this functionality for the applications that don't have a web-based interface for normal users.
if NEWSLETTER_VALIDATE_USER is false in settings.py then it will not check for email in the User model.
fixes #369