Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests with passwords are mocked out -> docker containers #360

Open
jonathan-s opened this issue Oct 29, 2020 · 2 comments
Open

Tests with passwords are mocked out -> docker containers #360

jonathan-s opened this issue Oct 29, 2020 · 2 comments

Comments

@jonathan-s
Copy link
Contributor

Because the actual command to the database is mocked out we don't get an end to end test, which is quite useful in a case like this.

To be able to get to an end to end testcase you'd need to make certain configurations for the databases themselves. Which leads to docker. We'd need to create some kind of testing container for the databases.

@ZuluPro
Copy link
Contributor

ZuluPro commented Dec 25, 2020

Hi @jonathan-s
You removed Travis CI, but there were functional tests:
https://github.com/django-dbbackup/django-dbbackup/blob/master/dbbackup/tests/functional/test_commands.py

Maybe we can add test with M2M and FK,
But this is supposed to work with any configured backend.

@jonathan-s
Copy link
Contributor Author

In travis the functional tests were only ever tested for sqlite from what I understand. Ideally the functional tests should be ran for all types of databases since it could technically fail for one database but suceed for another.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants