Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<figure> tag unable to show image #122

Open
yashg1 opened this issue Jun 24, 2018 · 1 comment
Open

<figure> tag unable to show image #122

yashg1 opened this issue Jun 24, 2018 · 1 comment

Comments

@yashg1
Copy link

yashg1 commented Jun 24, 2018

Hello,
Firstly, I love this theme. I would like to add figure captions and am using a [helper from minimal mistakes] (https://github.com/mmistakes/minimal-mistakes/blob/fc3e7a61769253f10d325525b0a7a334166f49ac/_includes/figure). I am unable to get the image to display (see screenshot below). It looks like the "figure tag" is not recognized. With the same code, an image is displayed in the minimal mistakes theme.

In my markdown file, I add the following code,

{% include figure image_path="/assets/images/unsplash-image-10.jpg" alt="this is a placeholder image" caption="This is a figure caption." %}

which renders the page as shown below,

image

Do I need to make change to any other files also?

I maybe making a naive mistake. Appreciate any insights.
Thanks

@jarrekk
Copy link
Owner

jarrekk commented Aug 2, 2018

@yashg1 from your code I guess you want to use figure tag like this:

<figure>
  <img src="img_pulpit.jpg" alt="The Pulpit Rock" width="304" height="228">
</figure>

So the code in this theme should be:

<figure>
	<img src="{{ site.img_path }}/img_pulpit.jpg" width="75%">
</figure>

Is this you want?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants