Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libVLC support #16

Closed
viggy96 opened this issue Aug 22, 2021 · 3 comments
Closed

libVLC support #16

viggy96 opened this issue Aug 22, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@viggy96
Copy link

viggy96 commented Aug 22, 2021

libVLC could be an option for SSA/ASS support while we wait (forever) for ExoPlayer to finally implement proper support for it. The Jellyfin Android TV app uses it and it works pretty well. It crashes occasionally, but overall its pretty good.
@jarnedemeulemeester
Copy link
Owner

Yes, libVLC would probably be the best way to support SSA/ASS subs for now. And is probably easier to implement than libmpv.

I think I will add it as an option in the settings to switch to VLC.
I will try to implement this sometime in the future.

@jarnedemeulemeester jarnedemeulemeester added the enhancement New feature or request label Aug 23, 2021
@viggy96
Copy link
Author

viggy96 commented Aug 23, 2021

MPV could also be worth a look. Someone else made a pull request to jellyfin-android with mpv support.

jellyfin/jellyfin-android#475

@jarnedemeulemeester
Copy link
Owner

I have implemented the mpv player from jellyfin/jellyfin-android#475 as an experimental option.

I will close this but feel free to open new issues if there are problems with the mpv player.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@viggy96 @jarnedemeulemeester