Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elements with role "gridcell" must be contained in an element with the role "row" #125

Open
dana-ross opened this issue Jul 13, 2022 · 2 comments

Comments

@dana-ross
Copy link

Describe the bug

Accessibility Insights reports an issue with Masonic's accessibility markup.

Masonic assigns a WAI-ARIA role of grid to the container, and a role of gridcell to each individual cell. However, per W3C there needs to be an element with role "row" around each visual row of cells:

Authors MUST ensure elements with role gridcell are contained in, or owned by, an element with the role row.

To Reproduce
Run an Accessibility Insights FastPass scan on a web page using Masonic (the codesandbox demo works if you enable additional permissions for the extension to see the iframe). The error will be listed under "aria-required-parent".

Screen Shot 2022-07-13 at 7 18 26 PM

Expected behavior
A Masonic grid should contain standards-compliant markup which passes an accessibility scan.

Screenshots
n/a

Desktop (please complete the following information):

  • OS: n/a
  • Browser n/a
  • Version n/a

Smartphone (please complete the following information):

  • Device: n/a
  • OS: n/a
  • Browser n/a
  • Version n/a

Additional context
n/a

@dana-ross
Copy link
Author

I was able to work around this in our application by setting role="list" on the <Masonry> tag which is fine for us

@jaredLunde
Copy link
Owner

Feel free to submit a PR 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants