Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error on Android Studio 3.4 #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ buildscript {
google()
}
dependencies {
classpath 'com.android.tools.build:gradle:3.3.1'
classpath 'com.android.tools.build:gradle:3.4.0'

// NOTE: Do not place your application dependencies here; they belong
// in the individual module build.gradle files
Expand Down Expand Up @@ -75,4 +75,4 @@ ext {
junitVersion = '4.12'
espressoVersion = '3.1.0'
mockitoVersion = '2.15.0'
}
}
12 changes: 6 additions & 6 deletions config/quality/quality.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ task checkstyle(type: Checkstyle, group: 'Verification', description: 'Runs code
reports {
xml.enabled = true
xml {
destination "$reportsDir/checkstyle/checkstyle.xml"
destination file("$reportsDir/checkstyle/checkstyle.xml")
}
}

Expand All @@ -73,10 +73,10 @@ task findbugs(type: FindBugs,
xml.enabled = true
html.enabled = false
xml {
destination "$reportsDir/findbugs/findbugs.xml"
destination file("$reportsDir/findbugs/findbugs.xml")
}
html {
destination "$reportsDir/findbugs/findbugs.html"
destination file("$reportsDir/findbugs/findbugs.html")
}
}

Expand All @@ -98,10 +98,10 @@ task pmd(type: Pmd, group: 'Verification', description: 'Inspect sourcecode for
xml.enabled = true
html.enabled = true
xml {
destination "$reportsDir/pmd/pmd.xml"
destination file("$reportsDir/pmd/pmd.xml")
}
html {
destination "$reportsDir/pmd/pmd.html"
destination file("$reportsDir/pmd/pmd.html")
}
}
}
}
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-4.10.1-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-5.1.1-all.zip