Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event/Growl notifications on client desktop machines #425

Open
corrados opened this issue Jul 3, 2020 · 7 comments
Open

Event/Growl notifications on client desktop machines #425

corrados opened this issue Jul 3, 2020 · 7 comments
Labels
feature request Feature request

Comments

@corrados
Copy link
Contributor

corrados commented Jul 3, 2020

Allow Jamulus optionally to send visual event notifications using the host OS's notification function.

Examples including but not necessarily limited to:

  • Player entering/leaving server
  • Chat message notifications

Which events (or event types) to show should be configurable in Settings.

@corrados corrados added the feature request Feature request label Jul 3, 2020
@gilgongo
Copy link
Member

gilgongo commented Jul 5, 2020

Is this ticket about event notifications in general? I can see a use case for an OS-based notifications option. For example, "server recording has been turned on", "[name] sent a chat message", or even "Delay has been too high for too long".

@pljones
Copy link
Collaborator

pljones commented Jul 5, 2020

With >=Qt5.6 (I understand), qInfo(), etc use system logging, so server events captured that way are covered. If you're running Jamulus Server on Linux, built with >=Qt5.6 and running under systemctl, for example, you should be able to run journalctl -f -u jamulus-server (or whatever your unit name is) to tail the messages. This is also capturing client connects and server stop messages.

So that raises potential concerns over how much GDPR impact there would be if the mechanism you used for notifications also allowed logging.

There's a separate Issue about debugging logs, too. It can be very useful to say "OK, try that again but run with --debug logfile.txt", rather than having someone try to explain how to recreate a problem. Assuming you've added all the necessary debug code...

@gilgongo
Copy link
Member

gilgongo commented Jul 5, 2020

So that raises potential concerns over how much GDPR impact

In practice, there would be none relating to IP addresses, although it would help if Jamulus let server operators conform to the spirit of that law by notifying their users of the issues relating to IPs and names, as per #367

I think this ticket is more about event notifications on client desktop machines though, no?

@corrados
Copy link
Contributor Author

corrados commented Jul 5, 2020

I think this ticket is more about event notifications on client desktop machines though, no?

Good question. I would say yes.

I just ported the Issue from Sourceforge. I am not sure if the originator of the feature requests reads this forum here at Github.

@gilgongo gilgongo changed the title Audio or visual notification or chat message and/or musician incoming or leaving Integrate with desktop notifications Dec 15, 2020
@gilgongo
Copy link
Member

Editing the ticket to summarise it better. If anyone wants to pick it up and run with it, please do so.

@gilgongo gilgongo changed the title Integrate with desktop notifications Event/Growl notifications on client desktop machines though Feb 19, 2021
@gilgongo gilgongo changed the title Event/Growl notifications on client desktop machines though Event/Growl notifications on client desktop machines Feb 19, 2021
@gilgongo
Copy link
Member

Seems like this has been addressed by #2640 so I'll close.

@pljones pljones reopened this Jul 14, 2022
@pljones
Copy link
Collaborator

pljones commented Jul 14, 2022

#2640 uses audio notifications. This issue is for OS popups. The two aren't particularly related.

@ann0see ann0see added this to Tracking Jul 1, 2023
@github-project-automation github-project-automation bot moved this to Triage in Tracking Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Feature request
Projects
Status: Triage
Development

No branches or pull requests

3 participants