Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor release upload into two parts #3374

Merged

Conversation

ann0see
Copy link
Member

@ann0see ann0see commented Sep 14, 2024

Short description of changes

CHANGELOG: Refactor Release upload to two step process
Context: Fixes an issue?

Fixes: #3373 (deploy/) issue

Does this change need documentation? What needs to be documented and how?

No

Status of this Pull Request

Ready for review

What is missing until this pull request can be merged?

Nothing. Works. The error doesn't show up on my repo.

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@ann0see ann0see added this to the Release 3.11.0 milestone Sep 14, 2024
@ann0see ann0see requested a review from pljones September 15, 2024 08:20
@ann0see ann0see requested a review from softins September 15, 2024 20:01
Copy link
Member

@softins softins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks ok, but I see none of the CI jobs for the PR executed the changed steps.
Would probably be good to run a temporary test release (or pre-release?) to exercise the steps.

@ann0see
Copy link
Member Author

ann0see commented Sep 16, 2024

https://github.com/ann0see/jamulus/releases/tag/r0_3_10_0

@ann0see ann0see merged commit bf844a0 into jamulussoftware:main Sep 16, 2024
12 checks passed
@ann0see ann0see deleted the autobuild/refactorReleaseUpload branch September 16, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Build process error and warning for 3.11.0rc1
3 participants