Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Prepare release" template "Finish App translations" change #1071

Closed
pljones opened this issue Aug 30, 2024 · 2 comments
Closed

"Prepare release" template "Finish App translations" change #1071

pljones opened this issue Aug 30, 2024 · 2 comments
Labels
bug Something isn't working release process Changes to the release process
Milestone
Release 3.12.0

Comments

@pljones
Copy link
Contributor

pljones commented Aug 30, 2024

Currently, "Finish App translations" reads"

  • Finish App translations
    • Review translation PRs according to release process checklist
    • Wait for all PRs to be merged (missing translations will revert to English automatically).
    • Check for conflicting accelerator keys (see tools/checkkeys.pl)
    • Check for broken links

"Check for broken links" is a website check -- so it needs removing from the "Finish App translations".

Originally posted by @pljones in jamulussoftware/jamulus#3255 (comment)
@pljones pljones added this to the Release 3.12.0 milestone Aug 30, 2024
@ann0see
Copy link
Member

ann0see commented Aug 30, 2024

Yes. Even though we link to the website from within the app, I don't think it's the case in many places

@pljones pljones added the bug Something isn't working label Aug 30, 2024
@pljones pljones added the release process Changes to the release process label Sep 22, 2024
@pljones pljones transferred this issue from jamulussoftware/jamulus Dec 18, 2024
@pljones
Copy link
Contributor Author

pljones commented Dec 18, 2024

Looks like this has already been fixed? Maybe I used an old template last time.

@pljones pljones closed this as completed Dec 18, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Tracking Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working release process Changes to the release process
Projects
Tracking
Status: Done
Milestone
Release 3.12.0
Development

No branches or pull requests
2 participants
@pljones @ann0see