Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show ASIO Device settings and open ASIO settings on JACK version of Jamulus #2186

Closed
ann0see opened this issue Dec 25, 2021 · 4 comments · Fixed by #2215
Closed

Do not show ASIO Device settings and open ASIO settings on JACK version of Jamulus #2186

ann0see opened this issue Dec 25, 2021 · 4 comments · Fixed by #2215
Milestone

Comments

@ann0see
Copy link
Member

ann0see commented Dec 25, 2021

Documenting for future fixing. In theory this is a good first issue ;-). However the description is for the team.

Currently we still show the ASIO device settings button (probably somewhere in settings) and the open ASIO settings button in soundbase.cpp even if we compile the JACK version on windows. We should not use #ifdef _WIN32 in these files.

See:

Is this defined if we're running JACK on Windows? If so, it's the wrong symbol.

Originally posted by @pljones in #2168 (comment)

@ann0see ann0see added this to the Release 3.9.0 milestone Dec 25, 2021
@gilgongo
Copy link
Member

Just a meta point: issues in "triage" are for when we've not decided if we want to deal with them yet. Issues with a milestone can't be in triage, so i've moved this to "backlog" as I assume we've decided we will work on it.

@pljones
Copy link
Collaborator

pljones commented Feb 23, 2022

Just checking -- this has 3.9.0 but looks like it went into 3.8.2, is that right?

@ann0see
Copy link
Member Author

ann0see commented Feb 23, 2022

Yes, I think so.

@hoffie hoffie modified the milestones: Release 3.9.0, Release 3.8.0 Feb 23, 2022
@hoffie
Copy link
Member

hoffie commented Feb 23, 2022

Yep. I've updated the milestone.

@pljones pljones modified the milestones: Release 3.8.0, Release 3.8.2 Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants