-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scrollbars to settings dialog #1530
Add scrollbars to settings dialog #1530
Conversation
You can get 20% more room! (3 FAT lines worth) without resorting to scroll-bars.
|
Thanks, I guess that could be possible. I was just adding a minimal change, but more in depth modifications probably should be discussed with @dcorson-ticino-com (I understand was the responsible of the latest redesign of the UI). |
Not responsible, but proposing things ;) One of the reasons for trying a single window UI was for tablets, but as I don't have one it is all theoretical. |
I tried a version with the stats/checkbox on the right: |
This PR pre-dates the changes to the Settings dialogue. Can it be closed now? Does it need redoing from scratch (in which case the PR could be closed until the new version is ready)? |
For me it is not necessary, but let's see what the OP says. |
Not really sure. I'll try to have a look at the current status of master over the weekend, but please go ahead and close if you think the PR is no longer needed. |
The settings dialog for me, on Windows and Android is fine. Yes, if you want to, you can make the window too small on Windows. That could be fixed by setting the minimum width of the various containers correctly (possibly dynamically based on content). |
Closing due to inactivity. Probably the GUI issue is even worse on iOS, so definitly something needs to be done. But that's out of scope ;-) |
Trying to fix #1529