Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scrollbars to settings dialog #1530

Conversation

j-santander
Copy link
Contributor

Trying to fix #1529

@ghost
Copy link

ghost commented Apr 18, 2021

You can get 20% more room! (3 FAT lines worth) without resorting to scroll-bars.

  • put Device beside the selector (as Audio Channels and Audio Quality is)
  • do the same with Buffer Delay (Buffer is good enough Delay is too much)
  • get rid of Measurements (heading)

@j-santander
Copy link
Contributor Author

You can get 20% more room! (3 FAT lines worth) without resorting to scroll-bars.

* put Device beside the selector (as Audio Channels and Audio Quality is)

* do the same with Buffer Delay (Buffer is good enough Delay is too much)

* get rid of Measurements (heading)

Thanks, I guess that could be possible. I was just adding a minimal change, but more in depth modifications probably should be discussed with @dcorson-ticino-com (I understand was the responsible of the latest redesign of the UI).

@dcorson-ticino-com
Copy link
Contributor

Not responsible, but proposing things ;)
Could you try out my NewUI-DCO on your tablet and let me know how it works.
https://github.com/dcorson-ticino-com/jamulus/releases/tag/r3_8_0beta3NewUI

One of the reasons for trying a single window UI was for tablets, but as I don't have one it is all theoretical.

@pljones
Copy link
Collaborator

pljones commented Apr 19, 2021

I tried a version with the stats/checkbox on the right:
#1542

@pljones
Copy link
Collaborator

pljones commented Jun 19, 2021

This PR pre-dates the changes to the Settings dialogue. Can it be closed now? Does it need redoing from scratch (in which case the PR could be closed until the new version is ready)?

@dcorson-ticino-com
Copy link
Contributor

For me it is not necessary, but let's see what the OP says.

@j-santander
Copy link
Contributor Author

Not really sure. I'll try to have a look at the current status of master over the weekend, but please go ahead and close if you think the PR is no longer needed.
Thanks

@pljones
Copy link
Collaborator

pljones commented Jun 19, 2021

The settings dialog for me, on Windows and Android is fine. Yes, if you want to, you can make the window too small on Windows. That could be fixed by setting the minimum width of the various containers correctly (possibly dynamically based on content).

@ann0see
Copy link
Member

ann0see commented Jan 2, 2022

Closing due to inactivity. Probably the GUI issue is even worse on iOS, so definitly something needs to be done. But that's out of scope ;-)

@ann0see ann0see closed this Jan 2, 2022
@pljones pljones added the Mobile UI Issues with the UI on mobile platforms label Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile UI Issues with the UI on mobile platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile: Bad layout of settings dialog
4 participants