Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: Bad layout of settings dialog #1529

Open
j-santander opened this issue Apr 17, 2021 · 11 comments
Open

Mobile: Bad layout of settings dialog #1529

j-santander opened this issue Apr 17, 2021 · 11 comments
Labels
bug Something isn't working Mobile UI Issues with the UI on mobile platforms
Milestone

Comments

@j-santander
Copy link
Contributor

Describe the bug

With the code from master, the settings dialog in android is not layout correctly, with the rows appearing compressed as the screen is not tall enough.

To Reproduce

Install the latest application in android.

Expected behavior

Dialog should be layed out properly.

Screenshots

Screenshot_20210417-191524

Operating system

Android 11 - Google Pixel 3a

Version of Jamulus

Built from source at 3df60d6

Additional context

@j-santander j-santander added the bug Something isn't working label Apr 17, 2021
@ngocdh
Copy link
Contributor

ngocdh commented Apr 17, 2021

I confirm the issue. And it’s actually worse for iOS. In iOS, the issue exists for ClientDlg as well, where Android does much better.
This might have to do with how Qt deals with different OSes.

@ghost
Copy link

ghost commented Apr 18, 2021

You can get 20% more room! (3 FAT lines worth) without resorting to scroll-bars.

  • put Device beside the selector (as Audio Channels and Audio Quality is)
  • do the same with Buffer Delay (Buffer is good enough Delay is too much)
  • get rid of Measurements (heading)

@ngocdh
Copy link
Contributor

ngocdh commented Apr 18, 2021

I confirm the issue. And it’s actually worse for iOS. In iOS, the issue exists for ClientDlg as well, where Android does much better.
This might have to do with how Qt deals with different OSes.

This is how it looks actually in iOS.

47A89825-4655-4124-B4C9-8C5D5C926B44
C009C8F1-32C2-4415-90DE-11C9872C62FB

@ngocdh
Copy link
Contributor

ngocdh commented Apr 21, 2021

Could anyone point me in the right direction to fix the UI for iOS? I couldn't figure it out, since the same code is working quite well for other platforms, even Android. Somehow the ClientDlg now looks even worse: I can now see only 2 sliders (the lower part only) in the mixer.

6BF420CE-EF95-4940-BA17-C650C9E9FB21

@ann0see
Copy link
Member

ann0see commented May 24, 2021

You could open the UI in Qt Designer?

@ngocdh
Copy link
Contributor

ngocdh commented May 25, 2021

You could open the UI in Qt Designer?

Yes.

@ann0see
Copy link
Member

ann0see commented May 25, 2021

Ok. Probably you need to play CX around with the spacers/items there to get a working UI

@ngocdh
Copy link
Contributor

ngocdh commented May 25, 2021

I tried. But couldn't make it work due to my very limited experience. There are two problems:

  • For iOS: it seems the UI is rendered in low resolution, in contrary to Android, where everything is rendered perfectly
  • For touch screens in general: The mixer should support touch screen so that user can navigate easily, small scrollbars around the mixer is not the best solution here. Qt must surely support touch screen right?

@ann0see
Copy link
Member

ann0see commented May 25, 2021

Qt must surely support touch screen right?

Yes but this requires QML and probably a large rewrite of the whole UI.

Found https://wiki.qt.io/How_to_Port_From_Desktop_to_Mobile

@hoffie hoffie changed the title Bad layout of settings dialog in Android Android: Bad layout of settings dialog Mar 12, 2022
@ann0see ann0see added this to Tracking Jul 1, 2023
@github-project-automation github-project-automation bot moved this to Triage in Tracking Jul 1, 2023
@pljones
Copy link
Collaborator

pljones commented Aug 12, 2023

I think we probably do need a complete UI rewrite in the near future for mobile support.
Screenshot_20230812-121222
Decisions about how to lay out the screen haven't been based on which controls are necessary for use and which are merely informational.

@pljones pljones added the Mobile UI Issues with the UI on mobile platforms label Aug 12, 2023
@ann0see
Copy link
Member

ann0see commented Aug 12, 2023

Agree. There were concepts for a new UI somewhere.

@pljones pljones changed the title Android: Bad layout of settings dialog Mobile: Bad layout of settings dialog Jun 29, 2024
@ann0see ann0see added this to the Release 4.0.0 milestone Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Mobile UI Issues with the UI on mobile platforms
Projects
Status: Triage
Development

Successfully merging a pull request may close this issue.

4 participants