add workaround for cut off buffer delay text #2291
Conversation
|
Meta: CodeQL CI check failed because the PR is not based on the very latest |
It looks to me like the label space is actually getting auto-sized according to the length of the text already, but that the metrics of the font are being slightly miscalculated (at least on that platform), resulting in the calculated width of the bounding box being slightly too small. This looks like a platform or Qt bug to me, and probably the proposed workaround is the easiest way to solve it. |
|
I was about to suggest merging as-is if there's no other obvious fix (maybe some Qt css @dzpex Does this affect a fresh Ubuntu profile or could it be related to some non-standard Qt layout or font setting? |
|
Needs rebasing to current master, I think. |
When choosing a non-predefined buffer delay, the text is cut off. Appending 2 space characters seems to fix the problem. Fixes jamulussoftware#1430 Signed-off-by: Martin Kaistra <[email protected]>
djfun
force-pushed
the
bugfix/buffer-delay-cut-off
branch
from
884af89 to
573dae6
Compare
| @@ -823,7 +823,8 @@ void CClientSettingsDlg::UpdateSoundCardFrame() | |||
| else | |||
| { | |||
| // special title text with buffer size information added | |||
| grbSoundCrdBufDelay->setTitle ( tr ( "Buffer Delay: " ) + GenSndCrdBufferDelayString ( iCurActualBufSize ) ); | |||
| // append 2 whitespace characters, so that the text doesn't get cut off | |||
| grbSoundCrdBufDelay->setTitle ( tr ( "Buffer Delay: " ) + GenSndCrdBufferDelayString ( iCurActualBufSize ) + " " ); | |||
There was a problem hiding this comment.
Although it doesn’t look like the cause is fixed with that, it’s a workaround which doesn’t seem to have negative side effects. I‘d say it’s ready?
There was a problem hiding this comment.
Can anyone confirm this original issue at all? And therefore, confirm the fix? If yes, I'd say go for it (maybe add a TODO comment to work out something better one day).
If anyone wants to dive deeper (I can't as I don't see this issue on my system). GammaRay might help.
There was a problem hiding this comment.
It doesn’t occur for me under Gnome 3.38.5 X11 or Wayland either
There was a problem hiding this comment.
I am currently using Ubuntu 20.10 with Gnome 40.4.0 and Wayland. Did you test on Ubuntu? It might depend on the UI font, which is "Ubuntu Regular, 11" for me (you can set that with gnome-tweaks)
There was a problem hiding this comment.
See also #1430 (comment)
(I chose to post the original issue again as the reproducability is more issue-related than PR-related, but it's... not entirely clear. ;))
There was a problem hiding this comment.
The PR should include "after" screenshots if they're not included in the issue (which they're not here).
|
I think a decision should be made if we merge this. Pro: |
|
@djfun @pljones @hoffie How can we proceed here? See my comment above: #2291 (comment) |
|
Closing this PR in favor of #1430 (comment) @djfun maybe you could work on the alternative approach? |
|
I've got some half-ready code for that, but it hasn't been fully tested which is why I haven't submitted a PR yet. |
Short description of changes
When choosing a non-predefined buffer delay, the text is cut off. Appending
2 space characters seems to fix the problem.
Context: Fixes an issue?
Fixes: #1430
Does this change need documentation? What needs to be documented and how?
no
Status of this Pull Request
Waiting on other approach mentioned here: #1430 (comment)
What is missing until this pull request can be merged?
nothing
Checklist