windows/sound.cpp: Rename CheckDeviceCapabilities()

[hoffie]

Describe the bug
CheckDeviceCapabilities() in windows/sound.cpp does more than what the name suggests: It has side effects such as updating instance variables such as lNumInChan.

Expected behavior

Have a name which makes it clear that updates happen.

Version of Jamulus
d5d4691

cc @ann0see @pljones

[DominikSchaller]

Maybe a stupid question, but what does "good first issue" mean? Does it mean, it's a good issue for a new developer?

[hoffie]

what does "good first issue" mean? Does it mean, it's a good issue for a new developer?

Yes, this was the intention. I think this issue requires little Jamulus-specific context but could be worked on by some developer who is new to the project.

[ann0see]

Any news here? @DominikSchaller @henkdegroot or @pgScorpio (sorry for the pings...) do you want to rename the function?

[pgScorpio]

@ann0see

Any news here? @DominikSchaller @henkdegroot or @pgScorpio (sorry for the pings...) do you want to rename the function?

No, just wait for the sound redesign.... It's already changed there.

[T-Roel]

@hoffie and @pgScorpio is this issue still necessary? I'd like to start to contribute in the project and this is the only good first issue available.

[ann0see]

Thanks!

I believe it's still relevant.
Feel free to raise a PR - but be aware that the review process might take some time.

Concerning contributing: make sure to read the CONTRIBUTING.md file.

[softins]

Hi @T-Roel, neither @hoffie nor @pgScorpio are currently active on the Jamulus project.

I see this issue is a very old one. I've taken a quick look at it, and I don't think it is an important issue. And versions of the function are used in both Windows and Mac. I would be inclined to just close this issue as "Won't fix".

But we're always glad to welcome new contributors. Are you currently a user of Jamulus? And do you use Discord? We have a few Jamulus channels on there where developers chat.

[T-Roel]

@ann0see and @softins thank you very much for your feedback! Since it doesn't seem necessary to do this issue, could you recommend another good first one?

@softins I'm starting using Jamulus in order to investigate some cognitive aspects in networked music performance as part of my PhD. I don't use Discord, but I intend to create a profile to chat with the community :)

[softins]

@T-Roel cool! I've been told the Discord is currently only open to established team members - my bad! But I've just found you on Facebook, and I will make contact with you on Messenger to chat a bit.