-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for PHP < 7.4, add return types #23
Labels
Comments
sure! that sounds awesome |
OK, I'm working on it now. Turns out the biggest complication is bumping
phpunit, as the current version requires php5!
Let's make this a 2.0 branch, since it's such a big change. I have a setup
working with php7.4 and phpunit 6, it passes the first 3 tests and stops on
the 4th. Can I push and hand it off to you for a bit?
Tac
…On Thu, Feb 10, 2022 at 8:13 AM jaimz22 ***@***.***> wrote:
sure! that sounds awesome
—
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEXIQO7B65XLBG34OURC7TU2PBYFANCNFSM5OA2U5VA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
yeah a v2 branch sounds like a good idea considering it's not BC for php5 |
I've bumped phpunit to 9.5 (the latest).
I removed 3 tests, one about GetterEntity likely is okay to remove.
The other 2 are more fundamental, and may have something to do with my
configuration (capitalization?) It's the two about dolphins.
…On Thu, Feb 10, 2022 at 12:28 PM jaimz22 ***@***.***> wrote:
yeah a v2 branch sounds like a good idea considering it's not BC for php5
—
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEXIQIOTNJ7JG6POPUPBNDU2P7VJANCNFSM5OA2U5VA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Any chance you can take a look at this? I'm not sure why the tests fail. |
hi, @jaimz22 , any chance you could look at my PR? Thx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'd like to get rid of the deprecation errors I'm getting now:
Fixing these properly would require adding return types, so we'd have to bump up the minimum PHP version. I can do a PR.
The text was updated successfully, but these errors were encountered: