Orange error checking invalid

[Aphexus]

The error handling routine is broke. Uses goto error: and static if where the error label is not defined in the errored branch.

These lines occur around
1200 in serializer.d

    else static if (isPointer!(T))
    {
        static if (isFunctionPointer!(T))
		{
            goto error;
		}

        return deserializePointer!(T)(keyOrId, id).value;
    }

    else static if (isEnum!(T))
        return deserializeEnum!(T)(keyOrId, id);

    else
    {
        error:
        error(format!(`The type "`, T, `" cannot be deserialized.`));
    }
}

simply removing the final else should solve the problem and be sufficient.

Actually it doesn't and causes a serialization error to occur for obvious reasons. Better just to put in the error(...) directly and avoid the goto.

2. Does not handle delegate types properly and craps out after a lot of code.

"Error: new can only create structs, dynamic arrays or class objects, not bool(a,b)'s

This occurs around 1500:

    auto pointer = new UnqualfiedBaseType;

But starts earlier. I can see that

instantiated from here: deserializeInternal!(bool function(a, b)
......\D\Libraries\orange\serialization\Serializer.d(1272): instantiated from here: objectStructDeserializeHelper!(Del!(bool function(a, b)))
......\D\Libraries\orange\serialization\Serializer.d(1175): instantiated from here: deserializeObject!(Del!(bool function(a, b))
......\D\Libraries\orange\serialization\Serializer.d(1689): instantiated from here: deserializeInternal!(Del!(bool function(a, b))
......\D\Libraries\orange\serialization\Serializer.d(1720): instantiated from here: objectStructDeserializeHelper!(Item)

It might be better to handle these better. If they need to be serialized somehow then a custom serializer would need to be used.

[jacob-carlborg]

What are you exactly doing? Is there an example you're compiling?