Numeric type is broken for small negative values

[kirk-anchor]

pgtype.Numeric does not work correctly for small negative values, e.g. -0.000123

	n := pgtype.Numeric{}
	n.Set("-0.000123")
	s := ""
	n.AssignTo(&s)
	fmt.Println(s)

Results in: 0.00-123 instead of -0.000123

[kirk-anchor]

Thanks for the fix! pggen still uses v4 and string conversion was needed for using numerics in composite types due to a pggen bug jschaf/pggen#102

[jschaf]

In an ironic turn of fate (as the pggen author), I had to skip pgtype v1.14.1 which includes fdca434.

Upgrading pgtype to v1.14.1 caused one of our tests to fail. A Postgres numeric value of 50 was decoded into a float64 as 5. Interestingly, it only broke a few tests so it's probably subtle.

I'll try to reproduce to see if it's something we're doing or something in pgtype.

[jschaf]

@jackc This looks like a pretty bad bug. I think pgtype.Numeric to float64 conversion is wrong for all values with an exponent of 1 divisible by 10, meaning [10, 20, 30, ..., 90]

[jackc]

Thanks @jschaf. Fix is merged and new release v1.14.2 is tagged.