Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yampa: Deprecate arr3, arr4, arr5 #313

Open
ivanperez-keera opened this issue Nov 29, 2024 · 1 comment
Open

yampa: Deprecate arr3, arr4, arr5 #313

ivanperez-keera opened this issue Nov 29, 2024 · 1 comment

Comments

@ivanperez-keera
Copy link
Owner

The functions arr3, arr4 and arr5 in the FRP.Yampa.Arrow module are not used in the wild. They also don't really belong in Yampa, since they are generic for arrows.

A search online shows that the functions can safely be removed (all the results are from Yampa or Yampa forks):

https://github.com/search?q=arr3+language%3AHaskell+Yampa&type=code

https://github.com/search?q=arr4+language%3AHaskell+Yampa&type=code

https://github.com/search?q=arr5+language%3AHaskell+Yampa&type=code

@ivanperez-keera
Copy link
Owner Author

ivanperez-keera commented Nov 30, 2024

If anyone wants to take this one, please go ahead and send a PR.

There'd only be two commits:

  • Commit 1: yampa: Deprecate FRP.Yampa.Arrow.arr3,arr4,arr5. Refs #313.

  • Commit 2: yampa: Document changes in CHANGELOG. Refs #313.

The message of the first commit would have to describe why this is happening. Feel free to grab ideas from the issue description.

Please check out the recent history of this repository to see how we normally document commits, and how we link commits to issues in the subject line of the commit messages. Make sure you use Refs <#issuenumber> in the summary line, etc. I like being very regular and explicit with commit messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant