Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How does this project work? #1

Open
jcbhmr opened this issue Mar 4, 2023 · 10 comments
Open

How does this project work? #1

jcbhmr opened this issue Mar 4, 2023 · 10 comments

Comments

@jcbhmr
Copy link
Collaborator

jcbhmr commented Mar 4, 2023

This is an issue tracking the documentation of how this website works. It's not necessarily a question per-se, but more of a "heyyyy let's document this stuff somewhere so we're all on the same page" issue.

@jcbhmr
Copy link
Collaborator Author

jcbhmr commented Mar 4, 2023

btw I was requested by @conartist6 to do something with this website in iter-tools/regex#47 (comment)

sooooo... yeah. we'll see what I can do if anything ❤

@jcbhmr
Copy link
Collaborator Author

jcbhmr commented Mar 4, 2023

Here's some info from the readme:

This is a Next.js project bootstrapped with create-next-app. It is using the Grommet component library and Typescript.

@conartist6
Copy link
Member

I did some work on it the other day: #2

@conartist6
Copy link
Member

The main goal is to visualize the states that are active in the engine. The engine states form a tree structure, and each state has a matcher, which can be represented either as a regex literal or as a graph structure as presented in a traditional railroad diagram visualization.

@conartist6
Copy link
Member

In terms of the matchers, those are defined in regex.ts. The type and props properties will be the important ones for building visualizations.

@conartist6
Copy link
Member

My rather medicore attempt to print matchers that powers the current playground is here

@jcbhmr
Copy link
Collaborator Author

jcbhmr commented Mar 4, 2023

Are we OK with splitting things out into new components, or do we want to freeze the components as-is and just add more stuff to them? Should the new components (the ez one that I spotted is abstracting the main <form> into its own thing) have the same React class-based components, are are we OK with new function-based components? Do we want to pick one over the other, or should we migrate to one? ANy preferences?

image
image
image

I note that some have function-style

image
image

image

if this were moved to a new component, we could then add more stuff to the main <App /> component like more docs, a header text, some more links in a footer, maybe a GitHub badge, etc.

@conartist6
Copy link
Member

Don't worry about offending me. If you think you can make anything better by changing how it's factored, where it lives, how it's documented, go right ahead!

@conartist6
Copy link
Member

I've given you write perms on the repo, so feel free to put your work in a branch here.

@jcbhmr
Copy link
Collaborator Author

jcbhmr commented Mar 4, 2023

Sounds good! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants