Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement query timeout + enable both v2 and v3 adapter tests #163

Merged
merged 1 commit into from
Oct 14, 2023
Merged

Conversation

isoos
Copy link
Owner

@isoos isoos commented Oct 14, 2023

Note: PgStatement.run has a breaking change in method signature. to be reviewed with the rest of v3 soon.

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d9f919b) 83.43% compared to head (239dc2b) 86.54%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
+ Coverage   83.43%   86.54%   +3.11%     
==========================================
  Files          30       30              
  Lines        2686     2698      +12     
==========================================
+ Hits         2241     2335      +94     
+ Misses        445      363      -82     
Files Coverage Δ
lib/postgres_v3_experimental.dart 51.16% <100.00%> (ø)
lib/src/v2_v3_delegate.dart 66.92% <100.00%> (+66.92%) ⬆️
lib/src/v3/connection.dart 87.87% <100.00%> (+0.65%) ⬆️
lib/src/v3/pool.dart 87.30% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isoos isoos merged commit 8811696 into master Oct 14, 2023
1 check passed
@isoos isoos deleted the timeout branch October 14, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants