Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal transaction support in v2 delegate. #152

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Minimal transaction support in v2 delegate. #152

merged 1 commit into from
Oct 11, 2023

Conversation

isoos
Copy link
Owner

@isoos isoos commented Oct 11, 2023

Enables error_handling_test.dart in V3=1 mode.

@codecov-commenter
Copy link

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (7c0f34d) 85.05% compared to head (9a74666) 84.58%.
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #152      +/-   ##
==========================================
- Coverage   85.05%   84.58%   -0.48%     
==========================================
  Files          30       30              
  Lines        2623     2640      +17     
==========================================
+ Hits         2231     2233       +2     
- Misses        392      407      +15     
Files Coverage Δ
lib/src/v3/connection.dart 87.46% <35.71%> (-0.62%) ⬇️
lib/src/v2_v3_delegate.dart 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isoos isoos merged commit bc43e22 into master Oct 11, 2023
1 check passed
@isoos isoos deleted the tx branch October 11, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants