Autodetect type from parameter value. (#154)

isoos · Oct 12, 2023 · 0287791 · 0287791
1 parent 9f79852
commit 0287791
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 6 deletions.
diff --git a/lib/src/v3/query_description.dart b/lib/src/v3/query_description.dart
@@ -67,6 +67,22 @@ class InternalQueryDescription implements PgSql {
       return value;
     } else if (knownType != null) {
       return PgTypedParameter(knownType, value);
+    } else if (value == null) {
+      return PgTypedParameter(PgDataType.voidType, value);
+    } else if (value is String) {
+      return PgTypedParameter(PgDataType.varChar, value);
+    } else if (value is bool) {
+      return PgTypedParameter(PgDataType.boolean, value);
+    } else if (value is int && value.bitLength <= 16) {
+      return PgTypedParameter(PgDataType.smallInteger, value);
+    } else if (value is int && value.bitLength <= 32) {
+      return PgTypedParameter(PgDataType.integer, value);
+    } else if (value is int && value.bitLength <= 64) {
+      return PgTypedParameter(PgDataType.bigInteger, value);
+    } else if (value is double) {
+      return PgTypedParameter(PgDataType.double, value);
+    } else if (value is DateTime) {
+      return PgTypedParameter(PgDataType.timestampWithoutTimezone, value);
     } else {
       throw ArgumentError.value(
         value,

diff --git a/test/variable_tokenizer_test.dart b/test/variable_tokenizer_test.dart
@@ -28,9 +28,11 @@ void main() {
         PgTypedParameter(PgDataType.text, 'z'),
       ],
     );
-    expect(() => desc.bindParameters({'x': 4, 'y': true, 'z': 'z'}),
-        throwsArgumentError,
-        reason: 'No data type given for z');
+    expect(desc.bindParameters({'x': 4, 'y': true, 'z': 'z'}), [
+      PgTypedParameter(PgDataType.bigInteger, 4),
+      PgTypedParameter(PgDataType.boolean, true),
+      PgTypedParameter(PgDataType.varChar, 'z'),
+    ]);
 
     // Make sure we can still bind by index
     expect(
@@ -42,9 +44,12 @@ void main() {
       ],
     );
     expect(
-      () => desc.bindParameters([1, true, 3]),
-      throwsArgumentError,
-      reason: 'No data type given for third parameter',
+      desc.bindParameters([1, true, 3]),
+      [
+        PgTypedParameter(PgDataType.bigInteger, 1),
+        PgTypedParameter(PgDataType.boolean, true),
+        PgTypedParameter(PgDataType.smallInteger, 3),
+      ],
     );
   });