Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL is broken #635

Closed
prologic opened this issue Aug 17, 2017 · 12 comments
Closed

SSL is broken #635

prologic opened this issue Aug 17, 2017 · 12 comments
Assignees

Comments

@prologic
Copy link

Getting an error creating an app:

$ API_URL=https://f.mydomain.com/ fn apps create myapp
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x14dae3d]

goroutine 1 [running]:
main.(*appsCmd).create(0xc42000c090, 0xc4200d7cc0, 0x1, 0x1616500)
	/home/ubuntu/go/src/github.com/iron-io/functions/fn/apps.go:148 +0x6cd
main.(*appsCmd).(main.create)-fm(0xc4200d7cc0, 0x0, 0xc4204b7a30)
	/home/ubuntu/go/src/github.com/iron-io/functions/fn/apps.go:35 +0x34
github.com/iron-io/functions/vendor/github.com/urfave/cli.HandleAction(0x155dca0, 0xc4204b7270, 0xc4200d7cc0, 0x1, 0x0)
	/home/ubuntu/go/src/github.com/iron-io/functions/vendor/github.com/urfave/cli/app.go:485 +0xd4
main.prepareCmdArgsValidation.func1(0xc4200d7cc0, 0x0, 0xc4200d7cc0)
	/home/ubuntu/go/src/github.com/iron-io/functions/fn/main.go:118 +0x357
github.com/iron-io/functions/vendor/github.com/urfave/cli.HandleAction(0x155dca0, 0xc42014c0e0, 0xc4200d7cc0, 0xc420071100, 0x0)
	/home/ubuntu/go/src/github.com/iron-io/functions/vendor/github.com/urfave/cli/app.go:485 +0xd4
github.com/iron-io/functions/vendor/github.com/urfave/cli.Command.Run(0x1617a77, 0x6, 0x0, 0x0, 0xc4204b7330, 0x1, 0x1, 0x16201c7, 0x10, 0x0, ...)
	/home/ubuntu/go/src/github.com/iron-io/functions/vendor/github.com/urfave/cli/command.go:193 +0xb72
github.com/iron-io/functions/vendor/github.com/urfave/cli.(*App).RunAsSubcommand(0xc4202409c0, 0xc4200d77c0, 0x0, 0x0)
	/home/ubuntu/go/src/github.com/iron-io/functions/vendor/github.com/urfave/cli/app.go:374 +0xacc
github.com/iron-io/functions/vendor/github.com/urfave/cli.Command.startApp(0x1615bf3, 0x4, 0x0, 0x0, 0x0, 0x0, 0x0, 0x162276d, 0x13, 0x0, ...)
	/home/ubuntu/go/src/github.com/iron-io/functions/vendor/github.com/urfave/cli/command.go:280 +0x824
github.com/iron-io/functions/vendor/github.com/urfave/cli.Command.Run(0x1615bf3, 0x4, 0x0, 0x0, 0x0, 0x0, 0x0, 0x162276d, 0x13, 0x0, ...)
	/home/ubuntu/go/src/github.com/iron-io/functions/vendor/github.com/urfave/cli/command.go:79 +0x14c7
github.com/iron-io/functions/vendor/github.com/urfave/cli.(*App).Run(0xc420240820, 0xc420078080, 0x4, 0x4, 0x0, 0x0)
	/home/ubuntu/go/src/github.com/iron-io/functions/vendor/github.com/urfave/cli/app.go:250 +0x7d0
main.main()
	/home/ubuntu/go/src/github.com/iron-io/functions/fn/main.go:126 +0x53
@c0ze
Copy link
Contributor

c0ze commented Aug 17, 2017

Hello, thanks for all the reports !

This is interesting, it seems fn doesn't get the response it expects.

https://github.com/iron-io/functions/blob/master/fn/apps.go#L148

I'll try to replicate your environment and check for the issue, in the mean time, would it be possible for you to try without https ? (just a hunch, also in light of #634 )

@prologic
Copy link
Author

Without https eh? Okay sure I'll try to figure out how to not make my env secure :D

@prologic
Copy link
Author

Okay so your hunch was right :)

$ API_URL=http://node1.mydomain.com:18080/ fn apps create myapp
myapp created

I'll retitle the issue. Let's fi this broken SSL support please :)

@prologic prologic changed the title fn apps create => nil pointer exception SSL is broken Aug 18, 2017
@prologic
Copy link
Author

NB: This is:

LB (traefik) -> functions service
      HTTPS  ->            whatever

@prologic
Copy link
Author

Also the current situation sucks because my environment redirects all http traffic to https and there is no way to turn this off specifically (lack of exclusion rules support) for a particular service/endpoint so functions/faas will not play nicely right now.

@c0ze
Copy link
Contributor

c0ze commented Aug 18, 2017

thank you, I will look into this.

@c0ze c0ze self-assigned this Aug 18, 2017
@c0ze c0ze mentioned this issue Sep 28, 2017
@c0ze
Copy link
Contributor

c0ze commented Sep 29, 2017

@prologic sorry for the long delay ! We just released a new version of the fn tool which should solve SSL issues. Please give it a try and let us know if this works for you !
Thanks !

@prologic
Copy link
Author

prologic commented Sep 29, 2017 via email

@c0ze
Copy link
Contributor

c0ze commented Nov 2, 2017

closing this for now, please feel free to open again if still not working for you 👍

@c0ze c0ze closed this as completed Nov 2, 2017
@prologic
Copy link
Author

prologic commented Nov 2, 2017 via email

@c0ze
Copy link
Contributor

c0ze commented Nov 2, 2017

We released a new version on sept 28th.

#650

You need to update your fn tool and iron/functions container to get the new version.

seems to be working (duplicate issue closed by OP)
#649

@prologic
Copy link
Author

prologic commented Nov 2, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants