Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document auxiliary test script setupssl.py #537

Closed
d-w-moore opened this issue Apr 13, 2024 · 6 comments
Closed

Document auxiliary test script setupssl.py #537

d-w-moore opened this issue Apr 13, 2024 · 6 comments
Assignees
Milestone

Comments

@d-w-moore
Copy link
Collaborator

          Consider reserving `-h` for printing the help text. Or add a few lines to the README explaining how to view the help text.

Originally posted by @korydraughn in #527 (comment)

@d-w-moore d-w-moore added this to the 2.1.0 milestone Apr 13, 2024
@d-w-moore d-w-moore self-assigned this Apr 13, 2024
@alanking
Copy link
Contributor

alanking commented Aug 1, 2024

I don't think -h is reserved for printing help text in any standard (counter-example: df -h). Plus, -h as an option for a hostname parameter has precedent in docker run and possibly other well-known programs.

The setupssl.py script already has a line saying how to view the help text:

Any invalid option prints this help.

So, what is this issue about?

@trel
Copy link
Member

trel commented Aug 1, 2024

-h In the generated certificate, use the given hostname rather than the value returned from socket.gethostname()

Since we already appear to have a collision, then... we use --help as well as 'any invalid option' if that is easily supported with getopt.

We should move to argparse in 3.0 as well... (#598)

@korydraughn
Copy link
Contributor

So, what is this issue about?

It was about -h being reserved for displaying help text.

That comment stemmed from the fact that when I want to see help text for a command, I always attempt to use -h. Of course, we don't have to standardize on that.

Since we already appear to have a collision, then... we use --help as well as 'any invalid option' if that is easily supported with getopt.

I agree.

@alanking
Copy link
Contributor

alanking commented Aug 1, 2024

Okay, so we can add a --help option and call this done?

@trel
Copy link
Member

trel commented Aug 1, 2024

if getopt allows 'long' options... i think so.

@trel
Copy link
Member

trel commented Aug 1, 2024

looks like it ... does. https://docs.python.org/2.7/library/getopt.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants