Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On error, send XML response not just HTTP code #97

Open
JustinKyleJames opened this issue Feb 18, 2024 · 2 comments
Open

On error, send XML response not just HTTP code #97

JustinKyleJames opened this issue Feb 18, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@JustinKyleJames
Copy link
Contributor

When errors are encountered, send the XML response as described here:

https://docs.aws.amazon.com/AmazonS3/latest/API/ErrorResponses.html

Currently we are only sending the HTTP code (404, 500, etc.). This seems to be sufficient with clients but we should be sending the full xml response with more descriptive information.

@korydraughn
Copy link
Collaborator

I'm thinking this is 0.3.0.

@JustinKyleJames Thoughts?

@trel
Copy link
Member

trel commented Feb 19, 2024

makes sense. 0.2.0 for immediate needs/functionality.

@trel trel added the enhancement New feature or request label Feb 19, 2024
@korydraughn korydraughn added this to the 0.3.0 milestone Feb 20, 2024
@trel trel modified the milestones: 0.3.0, 0.4.0 Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants