Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide version variable to use in main.cpp #128

Open
trel opened this issue Oct 3, 2024 · 1 comment
Open

provide version variable to use in main.cpp #128

trel opened this issue Oct 3, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone

Comments

@trel
Copy link
Member

trel commented Oct 3, 2024

https://github.com/irods/irods_client_s3_api/pull/125/files#diff-4e63c76ee16f6ffa00e678da80b43894b0aa6dad81d2730c227bf9ccc7753ee1

-    "$id": "https://schemas.irods.org/irods-s3-api/0.2.0/schema.json",
+    "$id": "https://schemas.irods.org/irods-s3-api/0.3.0/schema.json",

We would like to provide a variable here to prevent needing to update this string for every release.

_Originally posted by @trel in #125 (comment)

@trel trel added this to the 0.4.0 milestone Oct 3, 2024
@trel trel added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 3, 2024
@korydraughn
Copy link
Collaborator

Defining the value of either of the following as a macro will get us there.

set(IRODS_CLIENT_VERSION "0.2.0")
set(IRODS_S3_API_VERSION "${IRODS_CLIENT_VERSION}")

The macro can be defined for the target which compiles main.cpp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants