Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject multiple multipart uploads to the same key #127

Open
JustinKyleJames opened this issue Oct 3, 2024 · 2 comments
Open

Reject multiple multipart uploads to the same key #127

JustinKyleJames opened this issue Oct 3, 2024 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@JustinKyleJames
Copy link
Contributor

JustinKyleJames commented Oct 3, 2024

While I believe AWS allows multiple multipart uploads simultaneously to the same key, this doesn't make sense in the way we are implementing things as we are now sometimes writing parts directly to iRODS.

We should reject a CreateMultipartUpload request if there is already one in progress to that same key.

@trel trel added the enhancement New feature or request label Oct 3, 2024
@trel trel added this to the 0.4.0 milestone Oct 3, 2024
@korydraughn
Copy link
Collaborator

This will need to be documented in the README.

We also need to pick an appropriate HTTP status code to return to the client.

@trel
Copy link
Member

trel commented Oct 3, 2024

i propose...

409 Conflict - https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/409

In other systems, 409 responses may be used for implementation-specific purposes, such as to indicate that the server has received multiple requests to update the same resource.

https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/409#concurrent_tasks_disallowed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants