Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On-demand download of netlab topology #1388

Open
ipspace opened this issue Oct 17, 2024 · 2 comments
Open

On-demand download of netlab topology #1388

ipspace opened this issue Oct 17, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@ipspace
Copy link
Owner

ipspace commented Oct 17, 2024

Netlab commands that take topology file as input could accept URLs, download the URL content into downloaded.yml (or some such), and execute the rest of the command.

The "only" thing I'm worried about is the security. Should we warn the user that it's not safe to download and execute content without examining it?

@ipspace ipspace added the enhancement New feature or request label Oct 17, 2024
@jbemmel
Copy link
Collaborator

jbemmel commented Oct 17, 2024

Variant on this would be to specify a git url - have Netlab checkout the repo and launch the lab (assuming standard naming conventions)

Labs are often a collection of artifacts, not just single files

@ipspace
Copy link
Owner Author

ipspace commented Oct 17, 2024

Variant on this would be to specify a git url - have Netlab checkout the repo and launch the lab (assuming standard naming conventions)

You're effectively saying "replicate this: https://containerlab.dev/cmd/deploy/#remote-topology-files"

I love the idea, but let's make the "deploy from URL" the first step and go from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants