Skip to content
This repository has been archived by the owner on Aug 23, 2020. It is now read-only.

Have a tips provider that only holds solid valid tips #1811

Open
GalRogozinski opened this issue Mar 26, 2020 · 2 comments
Open

Have a tips provider that only holds solid valid tips #1811

GalRogozinski opened this issue Mar 26, 2020 · 2 comments
Labels
C-Data Model
Milestone
Mardi Gras

Comments

@GalRogozinski
Copy link
Contributor

GalRogozinski commented Mar 26, 2020 •
edited
Loading

Description

We want to update the tips container that we have now to hold only solid and valid bundles

Motivation

The tips will be used for tip-selection, we only want solid and valid ones

Requirements

  1. Only valid and solid tips should be present, anything that doesn't pass this definition is not a tip...
  2. GetNodeInfo for tips size should also work

Implementation details:

TipsViewModel should be separated to Tip (optional) and TipsProvider (DDD principles)
@GalRogozinski GalRogozinski added C-Data Model L-Groom This issue needs to be groomed labels Mar 26, 2020
@GalRogozinski GalRogozinski added this to the Mardi Gras milestone Mar 30, 2020
@GalRogozinski GalRogozinski removed the L-Groom This issue needs to be groomed label Mar 30, 2020
@acha-bill
Copy link
Contributor

TipsViewModel should be separated to Tip (optional) and TipsProvider (DDD principles)

Why do we need this?
A tip is only a Hash and the provider here is currently the TipsViewmodel.

@GalRogozinski
Copy link
Contributor Author

If we find that there is no need for a new model object then just rename TipsViewModel.
I deeply dislike everything that is named ViewModel in IRI

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
C-Data Model
Projects
None yet
Milestone
Mardi Gras
Development

No branches or pull requests
2 participants
@GalRogozinski @acha-bill