This repository has been archived by the owner on Aug 23, 2020. It is now read-only.
send heartbeat pulses and request tx using heartbeat #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,6 +22,8 @@ | |||
| import org.slf4j.Logger; | |||
| import org.slf4j.LoggerFactory; | |||
|
|
|||
| import java.util.List; | |||
There was a problem hiding this comment.
| import com.iota.iri.network.NeighborRouter; | ||
| import com.iota.iri.network.TipsRequester; | ||
| import com.iota.iri.network.TransactionRequester; | ||
| import com.iota.iri.network.*; |
There was a problem hiding this comment.
| private final SilentScheduledExecutorService executorService = new DedicatedScheduledExecutorService( | ||
| "Heartbeat Pulse"); | ||
|
|
||
| public HeartbeatPulseImpl(NeighborRouter neighborRouter, SnapshotProvider snapshotProvider) { |
There was a problem hiding this comment.
acha-bill
changed the title
kwek20
reviewed
Apr 14, 2020
| int max = 0; | ||
| for (PruningCondition condition: pruningConditions) { | ||
| if(condition.getSnapshotPruningMilestone() > max){ | ||
| max = condition.getSnapshotPruningMilestone(); |
There was a problem hiding this comment.
This should be the smallest milestone no? As we only prune the one that is lowest possible (to prevent pruning too much)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new thread that sends
heartbeatmessages to neighbours every minute.Then it requests txs only from neighbours who have the tx by checking their first and last solid milestone index from the heartbeat.
If the neighbour does not support protocol v2 yet, we request from it anyways.
Fixes #1798
Type of change
How Has This Been Tested?
Add unit tests that check that txs are broadcasted only from neighbors according to their heartbeat.
Checklist: