Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-import of ionic components fails when in-line comments are present #175

Open
i13-ctflora opened this issue Aug 13, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@i13-ctflora
Copy link

i13-ctflora commented Aug 13, 2024

I am 100% in love with the automatic importing of ionic components from the template - saves a lot of switching and helps keep me in the flow. However, I found today that the auto-importing suddenly stopped working on a single ionic template. I spent a bit of time tracking this issue down, and would like to know if there's a way around it?

After I added an in-line comment to the last member of my ionic angular import statement, the ionic extension would no longer automatically import any new Ionic components. For example:

import {
  IonContent,
  IonHeader,
  IonTitle, //these are the defaults
}

With that comment at the end, auto-importing no longer works. If there's a comment after the first or second member, auto-importing works with no problem. And it looks like the presence of the trailing comma does not make a difference.

Putting the comment below the last entry in the import statement works, eg:

import {
  IonContent,
  IonHeader,
  IonTitle, 
  //these are the defaults
}

Using the latest vscode (1.92.1), angular language service (18.2.0), and ionic extension (1.92.0). I obviously have a workaround - put the comment on the previous line or on a new line below the last member. But it'd be nice if I could put that comment back where I had it stylistically. I know this is pretty minor in the grand scheme of things, but hopefully it's an easy fix.

@dtarnawsky
Copy link
Collaborator

The auto importing replies on TS-Morph (https://github.com/dsherret/ts-morph). Looking to see how this can be resolved in that project.

@dtarnawsky dtarnawsky added the bug Something isn't working label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants