Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

any plan to support pnpm's workspace: and catalog: #171

Open
trydofor opened this issue Aug 13, 2024 · 3 comments
Open

any plan to support pnpm's workspace: and catalog: #171

trydofor opened this issue Aug 13, 2024 · 3 comments

Comments

@trydofor
Copy link

for example, the package.json

"dependencies": {
  "@local/front-shared": "workspace:*",
  "@capacitor/android": "catalog:",
  "@capacitor/app": "catalog:"
}

will show Unknown -> null in IONIC packages panel. to display version of workspace: and catalog: is more better.

in monorepos, defining the global version of the dependency (pnpm catalog) is very useful to manage the correct deps.

@dtarnawsky
Copy link
Collaborator

Are you able to supply a sample project that uses these? If so, I may be able to work out what pnpm is doing and add this as a feature in the extension.

@trydofor
Copy link
Author

Thanks first.

Are you able to supply a sample project that uses these?

take https://github.com/trydofor/professional-razor for example.
and in my vscode screenshot as follows,

image

@dtarnawsky
Copy link
Collaborator

I've done some research into this and even added a few improvements into the v1.93 release to detect catalog however the problem gets a little complex particularly if support is to extend past the extension and to commands like cap migrate.

The challenge is that the extension supports switching between projects in a monorepo but doesn't have all of the projects in a large structure so it can't easily traverse through the monorepo to work out where it would need to find version names, or how it would upgrade dependencies.

I'll leave this ticket open for the moment in case I get time to do the big refactor needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants