Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: ion-segment have incorrect tab sequence order (accessibility) #30022

Open
3 tasks done
jakobe opened this issue Nov 18, 2024 · 0 comments
Open
3 tasks done

bug: ion-segment have incorrect tab sequence order (accessibility) #30022

jakobe opened this issue Nov 18, 2024 · 0 comments
Labels

Comments

@jakobe
Copy link
Contributor

jakobe commented Nov 18, 2024

Prerequisites

Ionic Framework Version

v8.x

Current Behavior

Keyboard interaction for Tab key on ion-segment doesn't follow the Tabs Pattern in the ARIA Authoring Practices Guide (APG):

  • When focus moves into ion-segment (i.e. "tab list"), it doesn't place focus on the checked (i.e. "active") ion-segment-button (i.e. "tab element")
  • When ion-segment (i.e. "tab list") contains the focus, it doesn't moves focus to the next element in the page tab sequence outside ion-segment (i.e. "tab list"), but focuses the next ion-segment-button

Expected Behavior

I expect keyboard interaction in ion-segment to behave according to the Tabs Pattern in the ARIA Authoring Practices Guide (APG).
Pressing the Tab key on a Tab List should result in:

  1. When focus moves into the tab list, places focus on the active tab element
  2. When the tab list contains the focus, moves focus to the next element in the page tab sequence outside the tablist [...]

Note: rest of the keyboard interaction on ion-segment behaves as expected and according to the APG pattern 👌🏻

Steps to Reproduce

Please note: selecting MD mode in the examples makes it easer to see the currently focused segment button

  1. Places focus on the active tab element:
    1.1 Go to https://ionicframework.com/docs/api/segment#basic-usage
    1.2 Select the second segment button in the playground preview under "Basic Usage"
    1.3 Click outside the segment component to blur it (e.g. to the left or top of)
    1.4 Press the Tab key to focus the segment component
    1.5 See that the first segment contains focus (but focus should be on the checked, i.e. second, segment button)

  2. Move focus to the next element in the page tab sequence:
    2.1 Go to https://ionicframework.com/docs/api/segment#basic-usage
    2.2 Click inside the playground preview under "Basic Usage" (e.g. to the left or top of the segment component)
    2.3 Press the Tab key to focus the first segment button
    2.4 Press the Tab again
    2.5 See that the second segment contains focus (but focus should move to the next element in the page tab sequence outside the component)

Code Reproduction URL

https://ionicframework.com/docs/api/segment#basic-usage

Ionic Info

Ionic:
   Ionic CLI : 5.4.16
   Ionic Framework : @ionic/angular 8.2.7

Utility:
   cordova-res                          : not installed
   native-run (update available: 2.0.1) : 1.7.4

System:
   NodeJS : v20.11.1
   npm    : 10.2.4
   OS     : macOS Unknown

Additional Information

Currently each ion-segment-button inside ion-segment renders a native html button in it's shadow dom, which in turn acts as a tab stop in the page tab sequence, i.e. each button receives focus when the Tab key is pressed.

Before #26575 each ion-segment-button rendered with tabindex=-1 if not checked and tabindex=0 if checked (and not disabled). Each native button inside the shadow dom rendered with tabindex=-1.

This actually gave the correct tab order both when focusing the segment control (focus correctly being set on the checked segment button) as well as pressing the Tab key when the segment control contained focus (focus moved to the next element in the page tab sequence outside the control).

Maybe this can be re-introduced, but with the tabindex set on the native button?

To fully implement the Tabs Pattern from APG it should also implement a Roving Tabindex , i.e. set tabindex=0 on the currently focused button and tabindex=-1 on all other. When the segment component looses focus it should set tabindex=0 on the checked button (or the first button if none is checked) and tabindex=-1 on all other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant